search

migueldeicaza / MonoTouch.Dialog

Tools to simplify creating dialogs with the user using MonoTouch
MIT License
430 stars 211 forks source link

EntryElement should fire Changed event on Editing Changed #212

Closed gregorymartin closed 10 years ago

gregorymartin commented 10 years ago

Currently this event only fires when the user navigates away from the field. Including the EditingChanged will support more real-time monitoring of the field value.

migueldeicaza commented 10 years ago

I believe we used to do this, but it broke password entries, check the history of issues.

It is best to implement this behavior as a subclass

gregorymartin commented 10 years ago

Since the entry UITextField is private, what would be the recommended way to implement this behavior in a subclass? We would need a way to set the EditingChanged handler on the entry. Would an implementation that makes this behavior optional be accepted?

gregorymartin commented 10 years ago

Pull Request #211 includes an implementation for this as an option as well as a couple other enhancements to EntryElement to address other issues I logged.