Fix arithmetic overflow crash in unary minus operators

migueldeicaza / SwiftGodot

New Godot bindings for Swift

https://migueldeicaza.github.io/SwiftGodotDocs/tutorials/swiftgodot-tutorials/

MIT License

1.07k stars 70 forks source link

Fix arithmetic overflow crash in unary minus operators #368

Closed tishin closed 7 months ago

tishin commented 7 months ago

Follow-up to #359. Godot does not crash on arithmetic overflows, so neither should we.

migueldeicaza commented 7 months ago

I wonder if we should provide alternative operators that do not crash - so that we can preserve the Swift behavior of trapping on overflows.

tishin commented 7 months ago

I'd rather have alternatives that do crash. I don't think making native Godot interfaces crash under conditions when they're not supposed to crash is a good idea. That combined with Godot not having a proper crash reporting system is a nightmare fuel for me. Bindings users shouldn't wonder whether an operator or a method has a native non-crashing implementation or it's a Swifty crashing overload.

migueldeicaza commented 7 months ago

Makes sense.