Fix resolution of dynamic types when only proper supertypes are exposed through GDExtension

migueldeicaza / SwiftGodot

New Godot bindings for Swift

https://migueldeicaza.github.io/SwiftGodotDocs/tutorials/swiftgodot-tutorials/

MIT License

1.11k stars 74 forks source link

Fix resolution of dynamic types when only proper supertypes are exposed through GDExtension #493

Closed konczg closed 3 months ago

konczg commented 3 months ago

Originally, using Object.method_get_class meant that we tried using an object's dynamic type even if it was not registered with GDExtension, which resulted in falling back to the default case of using the static type from the method signature. This PR fixes this by introducing a call to gi.object_get_class_name, which will return the name of the most specialized subtype that is still registered with GDExtension. If this fails for some reason, we fall back to the previous method.

migueldeicaza commented 3 months ago

Thank you for your contributioN!