search

migueldeicaza / SwiftTerm

Xterm/VT100 Terminal emulator in Swift
MIT License
978 stars 145 forks source link

Use if canImport(...) instead of if os(...) #321

Closed migueldeicaza closed 1 year ago

Lakr233 commented 1 year ago

iirc, this will result a failure in Mac Catalyst app which can both import AppKit and UIKit. correct me if I'm wrong. :P

截屏2023-08-12 21 05 14 截屏2023-08-12 21 07 38
migueldeicaza commented 1 year ago

Thanks for the review.

I have not been considering catalyst, but that is a good call. I am afraid that generally the codebase is not really ready for Catalyst in this scenario :-(

Lakr233 commented 1 year ago

Thanks for the review.

I have not been considering catalyst, but that is a good call. I am afraid that generally the codebase is not really ready for Catalyst in this scenario :-(

Actually me and my team port your SwiftTerm to tvOS for fun and it works like a chram. :P

migueldeicaza commented 1 year ago

This should build on tvOS, but I have not tested it, used a different approach, since we needed this on visionOS