migueldeicaza / SwiftTermApp

MIT License
305 stars 29 forks source link

Design/Reminder: setupChannel calls session.activate (channel) until late, shouldn't it be done immediately? #171

Closed migueldeicaza closed 2 years ago

migueldeicaza commented 2 years ago

Or should channels always be activated implicitly to begin with?

Currently we create channels, but they need to be manually added to the list of pingable channels, but I wonder if we should always activate them instead - that would have avoided this code:

        // Now, make sure we process any data that might have been queued while we were setting up before the channel activation.
        let _ = await channel.ping()

And perhaps this is the source of other blocking operations, as we are calling things on the channel, but have no way of feeding them.

migueldeicaza commented 2 years ago

Done