migueldeicaza / XtermSharp

XTerm emulator as a .NET library
MIT License
161 stars 34 forks source link

TerminalController #53

Closed migueldeicaza closed 4 years ago

migueldeicaza commented 4 years ago

The recently introduced TerminalController was originally introduced to make the run-a-child-process scenario simpler to reuse without duplicating the code in the sample app.

Then the code was extended to handle scrolling. And now we have both TerminalView and TerminalController. I suspect this division could be better.

The scroll handling should be moved into TerminalView and the TerminalControl should probably be renamed ProcessTerminalView or something like that - reflecting the fact that this is a terminal that hosts a local process vs say, be a front-end to a remote network connection