migueldeicaza / XtermSharp

XTerm emulator as a .NET library
MIT License
161 stars 34 forks source link

Process terminal view #57

Closed sgmunn closed 4 years ago

sgmunn commented 4 years ago

Fixes #53 #54 #52

sgmunn commented 4 years ago

The thought occurs to me that LocalProcess could have an abstract ancestor "TerminalProcess" (?) and remote / connections could derive from that. LocalProcessTerminalView could be ProcessTerminalView (? ugh) or something nicer sounding. LocalProcessTerminalView.Process could even be just "Connection" and we could loosely describe a terminal view being connected to something (a local process, a remote process, etc).

~Maybe even just fold what's in LocalProcessTerminalView into terminal view altogether. Wasn't sure if welcome / exit text ought to be a part of TerminalView or not.~

edit: I looked briefly at making ProcessTerminalView a subclass of TerminalView but I wasn't happy with how I had to rewire events. I think this can be done but I need to take another look at what events need to be hooked up and how that can be done sanely and still allow for others to subclass / extend without breaking functionality.

sgmunn commented 4 years ago

Might need to come back and take another look at text selection. We also need to implement double click to select word etc