search

migueldvb / cine

Calculate infrared pumping rates by solar radiation
MIT License
3 stars 1 forks source link

Setuptools should be a requirement/bootstrapped #2

Closed eteq closed 7 years ago

eteq commented 7 years ago

If I try to do a python setup.py build on a minimal python setup, I get ImportError: No module named setuptools. There are two solutions I know of:

  1. use https://bootstrap.pypa.io/ez_setup.py as a bootstrap script which auto-installs setuptools.
  2. add "pip install setuptools" to the setup instructions (and maybe catch the import error in your setup.py)

I'd say just do 1, except that its notes say that approach is deprecated. So either of these work.

migueldvb commented 7 years ago

That is a good point. I have added a fallback import of setup from distutils. The setup.py script should work now with both setuptools and distutils.

eteq commented 7 years ago

(This is part of the review in openjournals/joss-reviews#182)

eteq commented 7 years ago

Great, thanks for the real-time peer review, @migueldvb ! ;)