search

migueleliasweb / go-github-mock

A library to aid unittesting code that uses Golang's Github SDK
MIT License
98 stars 24 forks source link

Removing redeclaration of GetScimV2OrganizationsUsersByOrgByScimUserId #11

Closed renzors closed 2 years ago

renzors commented 2 years ago

It is already declared in line 3145

migueleliasweb commented 2 years ago

Hi @renzors , the file src/mock/endpointpattern.go is auto generated so changing it wouldn't yield much result.

The ideal fix would be fixing the gen.go script to properly check if a given route was already created.

migueleliasweb commented 2 years ago

I'm working on improving the gen.go script and this problem should be fixed with it.

migueleliasweb commented 2 years ago

@renzors could you try to use the branch fix-gen-redeclarations and test the changes?

renzors commented 2 years ago

Hi @migueleliasweb, thanks for the quick review! Oh I see, I will use that branch and let you know, thanks!

renzors commented 2 years ago

Hi @migueleliasweb, it works perfect from fix-gen-redeclarations branch. Thanks!

renzors commented 2 years ago

Closing this PR, and waiting for the fix in the main branch :-)

migueleliasweb commented 2 years ago

The fix was merged. Thanks @renzors !