search

miguelfrde / travieso

Travis CI build job status directly on GitHub!
http://miguelfrde.github.io/travieso
MIT License
14 stars 1 forks source link

Will this still work when Authorization header is deprecated on TravisCI? #13

Open valscion opened 8 years ago

valscion commented 8 years ago

https://docs.travis-ci.com/user/notifications/#Authorization-for-Webhooks-(Deprecated)

Note: The Authorization header value described here is deprecated and will be discontinued on November 1, 2016

From quickly glancing at the current code, it seems like you do rely on this deprecated method to handle authorization, and it will fail after November 1. https://github.com/wizeline/travieso/blob/c74e689/travieso/core.py#L25

I was interested to try to integrate travieso in https://github.com/venuu/jsonapi-authorization/pull/34 but now I'm no longer sure that it would work much longer.

JAremko commented 7 years ago

Does it still work for you?

Btw Travis has Python example with new pubkey system.

valscion commented 7 years ago

I don't remember whether it worked or not. Due to here being no comments, I didn't want to put more effort in debugging this further.

Floppy commented 7 years ago

Not 100% sure if this is relevant, but I've just set up an instance and each POST to /notifications is resulting in a 403, so I suspect it's failing in exactly this way.