miguelfreitas / twister-core

twister core / daemon
MIT License
1.42k stars 251 forks source link

Question about Berkeley DB #259

Open thierry-FreeBSD opened 10 years ago

thierry-FreeBSD commented 10 years ago

In doc/build-unix.md, it is written that "You need Berkeley DB 4.8.".

However, it seems to build fine with a more recent version. Is there a reason for this 4.8 version, or is it just a recommendation?

earthengine commented 10 years ago

Usually this means "You need Berkeley DB 4.8+" or "You need Berkeley DB 4.8 or later" so it should be fine to use a later version.

dryabov commented 10 years ago

Twister-core can be used with Berkeley DB 5.x, but note that 4.8 and 5.x use different database format, so if you used 4.8 and then upgrade to 5.x, you have to manually convert your database to new format.

miguelfreitas commented 10 years ago

That's right. should be DB 4.8+.

The strict version requirement is a bitcoin thing, since they are worried about binary compatibility of wallets between computers.

I'm not much worried about that because: 1) we are still alpha/beta, 2) our primary distribution mechanism is source code not binary packages, 3) i believe users should backup their keys preferably by exporting in text format, printing, writing to a paper etc.

In fact, i'd even prefer getting rid of DB dependency altogether. Unlike bitcoin, typical usage of twister is only a few keys per wallet. We may probably be fine just using well defined text file format, possibly encrypted with a master key.