search

miguelfreitas / twister-core

twister core / daemon
MIT License
1.42k stars 251 forks source link

WebSocket... #423

Closed erqan closed 6 years ago

erqan commented 6 years ago

don't forget ./bootstrap.sh ...

miguelfreitas commented 6 years ago

Hi @erqan, excuse me for the long delay in reviewing this.

Websocket support is a great idea, thanks for working on it!

I'm just concerned that we are adding quite a lot of new code to twister compilation without adding a configure option to disable them. What do you think, may optionally disable compiling this extra code in a non messy way?

(btw, i have reviewed the code. above is my only objection, everything else is fine!)

erqan commented 6 years ago

@miguelfreitas last commit should make it optional

miguelfreitas commented 6 years ago

merged, thanks!

I actually got a compilation failure with websocket enabled due to some openssl defines: https://github.com/zaphoyd/websocketpp/issues/599 I'm unsure if we should rather fork their main repository to include the compilation fix instead.