search

miguelfreitas / twister-html

twister HTML + Javascript User Interface
MIT License
229 stars 138 forks source link

migrate to one page application #338

Open slr opened 8 years ago

slr commented 8 years ago

I don't like our current multi-page paradigm and I want to move all that options.html etc to home.html. (btw I saw with my own eyes how one person seeing abort.html after reboot of her computer was failing to understand what to do next to get her twister back to work).

what do you think?

ghost commented 8 years ago

abort.html is not useful also, +1 I'm ashamed, as dev, I've had this thing one time.

miguelfreitas commented 8 years ago

I have no objections!

What happened is that I originally intended to separate pages in order have simpler and more maintainable pages.

However, as some features then were required to be implemented in different pages (like profile and posts displaying in both home.html and following.html) it turned into a really bad idea, with lots of copy-pastes that actually made the maintainability worse, not better.

slr commented 8 years ago

I knew it won't be long discussion.

OK, I've started with converting of following.html to modal window in https://github.com/miguelfreitas/twister-html/commit/8c9c5f9293f21db086d2ef053669ca929fd84301 (sorry for such a messy commit; although this messiness with current mess in da code is like - and - for +, it's short way to more clean things). I suppose to convert all separate pages to modals and after that I want to rewrite initialization sequence to more straight state.

slr commented 5 years ago

profile-edit.html was converted to modal window too, see https://github.com/miguelfreitas/twister-html/commit/cecd428e5d458ec58cc7eb8af68fac4421b9d1ed