miguelfreitas / twister-html

twister HTML + Javascript User Interface

MIT License

229 stars 138 forks source link

add IPFS protocol links support #381

Closed ghost closed 3 years ago

ghost commented 3 years ago

Make native IPFS links clickable. Construction identical to the 'http' case. Was tested successfully.

slr commented 3 years ago

also notice please we do not merge pulls right into master branch. read readme again

ghost commented 3 years ago

I guess we do not want to apply proxyURL() for IPFS links

Oops... my mistake.

To make it easier for us to accept your patches, please follow the conventional GitHub workflow and keep in mind that your pull requests should have blaster branch as both the origin and target.

Hello) thanks for fixes, accepted - will pull updates into the blaster branch next time!

ghost commented 3 years ago

383

slr commented 3 years ago

@D4708 sorry for delay. I wasn't able to test it since I almost don't use my laptop these days - if only we have twister for mobiles!

ghost commented 3 years ago

Now I understand how does contribution work. I've tested each commit before pull request, other else mark it as ~untested~. Just checked - https://github.com/miguelfreitas/twister-html/pull/383 works fine.

Thank you for fixes and project maintenance!