miguelgrinberg / flask-sock

Modern WebSocket support for Flask.
MIT License
271 stars 24 forks source link

Ensure support for Python 3.12 and older versions #74

Closed Jamim closed 7 months ago

Jamim commented 7 months ago

Hello @miguelgrinberg,

Thank you for this library! 🙇🏻‍♂️

I believe it would be nice to ensure support for Python 3.12 and older versions, so I'd like to suggest changes that:

Unfortunately, I haven't found a way to make tox work with pyproject.toml on Python 3.6, so, as a workaround, pytest is used directly when testing against Python 3.6.

Best regards!

miguelgrinberg commented 7 months ago

While I appreciate this change, unfortunately I cannot accept it as currently formatted. There are a number of things that you have included that are trivial style preferences that do not actually improve the project in any way. Considering that I have to maintain over a dozen open source projects I prefer to keep everything consistent among them and when/if I decide to make CI improvements apply the same changes across the board.

Jamim commented 7 months ago

Thank you for the feedback! Your project, your rules. Is there a chance you consider accepting any of atomic PRs that, keeping existing style as much as possible

miguelgrinberg commented 7 months ago

I added 3.12 to the CI build, and also upgraded pypy to use the 3.10 compatible version. I'm not going to add 3.6 and I'm not going to add classifiers that will require constant updates. Sorry.