Closed Jamim closed 7 months ago
While I appreciate this change, unfortunately I cannot accept it as currently formatted. There are a number of things that you have included that are trivial style preferences that do not actually improve the project in any way. Considering that I have to maintain over a dozen open source projects I prefer to keep everything consistent among them and when/if I decide to make CI improvements apply the same changes across the board.
Thank you for the feedback! Your project, your rules. Is there a chance you consider accepting any of atomic PRs that, keeping existing style as much as possible
classifiers
that corresponds to Python version constraints (it's always better to see which versions are supported explicitly);requires-python = ">=3.6"
)?I added 3.12 to the CI build, and also upgraded pypy to use the 3.10 compatible version. I'm not going to add 3.6 and I'm not going to add classifiers that will require constant updates. Sorry.
Hello @miguelgrinberg,
Thank you for this library! 🙇🏻♂️
I believe it would be nice to ensure support for Python 3.12 and older versions, so I'd like to suggest changes that:
pyproject.toml
v3
tov4
v3
tov5
tox.ini
Unfortunately, I haven't found a way to make
tox
work withpyproject.toml
on Python 3.6, so, as a workaround,pytest
is used directly when testing against Python 3.6.Best regards!