search

miguelgrinberg / simple-websocket

Simple WebSocket server and client for Python.
MIT License
78 stars 17 forks source link

Include CHANGES.md and examples in PyPI sdists #32

Closed musicinmybrain closed 11 months ago

musicinmybrain commented 11 months ago

Add them to MANIFEST.in.

I don’t know if omitting these was intentional or not, but I would claim that it makes no less sense to include CHANGES.md than README.md, and that it makes sense to include examples if documentation is included.

miguelgrinberg commented 11 months ago

I'm going to pass on this, sorry. I manage many packages, and do not want to have custom changes in one vs others. I recently updated the packaging and release script to adapt to changes in the pypa tooling and for now I don't plan to make any more changes.

When I have to revise my release process again I can add the change log. It's unlikely that I will add examples. To me it sounds like you want to download the releases out of GitHub, not PyPI, as they have everything.

musicinmybrain commented 11 months ago

[…] I manage many packages, and do not want to have custom changes in one vs others.

In context, that’s quite reasonable.

To me it sounds like you want to download the releases out of GitHub, not PyPI, as they have everything.

Yes, that works fine.

Thanks for the quick response.