Add after and before streams

miguelgrinberg / turbo-flask

Integration of Hotwire's Turbo library with Flask.

MIT License

301 stars 35 forks source link

Add after and before streams #19

Closed janpeterka closed 2 years ago

janpeterka commented 2 years ago

Adding actions for after and before streams, added in v7.0.0

It seems like it works on v7.0.0-rc4, but it would be nice to include an update to v7.0.1 in this PR as well. I'm unsure how to do that. Will be glad for help on that.

I also guess there should be some test added for this?

[x] add after and before
[x] update to v7.0.1
[x] add tests?

miguelgrinberg commented 2 years ago

Thanks!

Can you please extend the test at https://github.com/miguelgrinberg/turbo-flask/blob/main/tests/test_turbo.py#L138 to include the two new stream types?

And then you can define the 7.0.1 version here: https://github.com/miguelgrinberg/turbo-flask/blob/main/src/turbo_flask/turbo.py#L9. The version information can be obtained from the CDN page at https://cdn.skypack.dev/@hotwired/turbo.

janpeterka commented 2 years ago

Not sure about the test, tried it naively.