search

miguelhincapie / CustomBottomSheetBehavior

Custom BottomSheetBehavior for Android that mimic Google Maps behavior
Apache License 2.0
915 stars 184 forks source link

to vit001 how to disable viewpager? #41

Open deividas717 opened 7 years ago

deividas717 commented 7 years ago

Thanks for the great library, however vit001 version has viewpager that has swipe effect. Is it possible to turn it off?

vit001 commented 7 years ago

Yes - provide a ViewPager Adapter with only one item.

On Mar 16, 2017 1:34 PM, "deiauk" notifications@github.com wrote:

Thanks for the great library, however vit001 version has viewpager that has swipe effect. Is it possible to turn it off?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/miguelhincapie/CustomBottomSheetBehavior/issues/41, or mute the thread https://github.com/notifications/unsubscribe-auth/ADoGr12F4RIyrP_MpTzx46L6wWDa2QX2ks5rmZzNgaJpZM4Mf18b .

vit001 commented 7 years ago

Or alternatively - check the setSwipeLeft(boolean) and setSwipeRight(boolean) methods in the adapter to disable swiping on the fly.

On Mar 16, 2017 1:34 PM, "deiauk" notifications@github.com wrote:

Thanks for the great library, however vit001 version has viewpager that has swipe effect. Is it possible to turn it off?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/miguelhincapie/CustomBottomSheetBehavior/issues/41, or mute the thread https://github.com/notifications/unsubscribe-auth/ADoGr12F4RIyrP_MpTzx46L6wWDa2QX2ks5rmZzNgaJpZM4Mf18b .

deividas717 commented 7 years ago

@vit001 thanks for quick reply! However this is not a clean solution. Is it possible to somehow not to use PagerAdapter at all? (I think most of the users want this functionality)

vit001 commented 7 years ago

Sorry, the vit001 fork requires a view pager with an adapter. I could not get all the features to work without the scrolling parent (viewpager).

On Mar 16, 2017 2:12 PM, "deiauk" notifications@github.com wrote:

@vit001 https://github.com/vit001 thanks for quick reply! However this is not a clean solution. Is it possible to somehow not to use PagerAdapter?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/miguelhincapie/CustomBottomSheetBehavior/issues/41#issuecomment-287192438, or mute the thread https://github.com/notifications/unsubscribe-auth/ADoGr4q0OSeO5kj7OJoDk8TE82ZubARdks5rmaWhgaJpZM4Mf18b .

miguelhincapie commented 7 years ago

The main version has some bugs that vit001 has fixed in his version, some day in the future I will update the main version.