NullPointerException at 288 line in BottomSheetBehaviorGoogleMapsLike

[frank-vi]

hi, i just want to test your app without adding code, but i get this error:

FATAL EXCEPTION: main java.lang.NullPointerException: Attempt to invoke virtual method 'void android.support.v4.widget.ViewDragHelper.processTouchEvent(android.view.MotionEvent)' on a null object reference at com.mahc.custombottomsheetbehavior.BottomSheetBehaviorGoogleMapsLike.onTouchEvent(BottomSheetBehaviorGoogleMapsLike.java:288) at android.support.design.widget.CoordinatorLayout.resetTouchBehaviors(CoordinatorLayout.java:389) at android.support.design.widget.CoordinatorLayout.onAttachedToWindow(CoordinatorLayout.java:235) at android.view.View.dispatchAttachedToWindow(View.java:15509) at android.view.ViewGroup.dispatchAttachedToWindow(ViewGroup.java:2916) at android.view.ViewGroup.dispatchAttachedToWindow(ViewGroup.java:2923) at android.view.ViewGroup.dispatchAttachedToWindow(ViewGroup.java:2923) at android.view.ViewGroup.dispatchAttachedToWindow(ViewGroup.java:2923) at android.view.ViewGroup.dispatchAttachedToWindow(ViewGroup.java:2923) at android.view.ViewGroup.dispatchAttachedToWindow(ViewGroup.java:2923) at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:1526) at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:1254) at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:6337) at android.view.Choreographer$CallbackRecord.run(Choreographer.java:874) at android.view.Choreographer.doCallbacks(Choreographer.java:686) at android.view.Choreographer.doFrame(Choreographer.java:621) at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:860) at android.os.Handler.handleCallback(Handler.java:751) at android.os.Handler.dispatchMessage(Handler.java:95) at android.os.Looper.loop(Looper.java:154) at android.app.ActivityThread.main(ActivityThread.java:6119) at java.lang.reflect.Method.invoke(Native Method) at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:886) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:776)

[miguelhincapie]

Hi, did you move any gradle config? (min SDK, libraries version,...) If not, can you give me more details about what you were doing and mobile specs (emulator or device)?

[frank-vi]

Hi, thanks for the replay. In the module-level build.gradle file i only add this library and Design Support Library. I have reported the complete file below.

`apply plugin: 'com.android.application'

android { compileSdkVersion 27 defaultConfig { applicationId "it.example.googlelike" minSdkVersion 18 targetSdkVersion 27 versionCode 1 versionName "1.0" testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner" } buildTypes { release { minifyEnabled false proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro' } } }

dependencies { implementation fileTree(dir: 'libs', include: ['*.jar']) implementation 'com.android.support:appcompat-v7:27.0.2' implementation 'com.android.support.constraint:constraint-layout:1.0.2' testImplementation 'junit:junit:4.12' androidTestImplementation 'com.android.support.test:runner:1.0.1' androidTestImplementation 'com.android.support.test.espresso:espresso-core:3.0.1'

implementation 'com.mahc.custombottomsheetbehavior:googlemaps-like:0.9.1'
implementation 'com.android.support:design:27.0.2'

}`

I use two emulators with these specifics:

Name: Nexus_4_API_25 CPU/ABI: Google APIs Intel Atom (x86) Target: google_apis [Google APIs] (API level 25) SD Card: 100M hw.lcd.height: 1280 hw.lcd.width: 768 hw.lcd.density: 320 vm.heapSize: 80 image.androidVersion.api: 25 image.sysdir.1: system-images\android-25\google_apis\x86\ showDeviceFrame: yes hw.ramSize: 1536 hw.cpu.ncore: 2 disk.dataPartition.size: 800M

and

Name: Pixel_API_18 CPU/ABI: Google APIs Intel Atom (x86) Target: google_apis [Google APIs] (API level 18) Skin: 1080x1920 SD Card: 100M hw.lcd.height: 1920 hw.lcd.width: 1080 hw.lcd.density: 480 vm.heapSize: 256 image.androidVersion.api: 18 hw.ramSize: 1536 hw.cpu.ncore: 2 disk.dataPartition.size: 800M

[repitch]

I assume it's cause 27.0.2 support library version. Now project works on 26.1.0 version.

[repitch]

I've just compared source code for original BottomSheetBehavior 26.1.0 - 27.0.2 and here what's changed: So, just need to add check mViewDragHelper for null

[repitch]

After upgrading to 27.0.2 and applying this fix something happened with swipe:

I'm figuring out why does it happen. For some reason mScrollVelocityTracker.clear() is called between onNestedPreScroll and onStopNestedScroll. So scrollVelocity is missing

[miguelhincapie]

@repitch thank you for that, you are welcome to create a PR with that improve :)

[repitch]

@miguelhincapie Working on that!

[repitch]

57 - pull request is created

[miguelhincapie]

PR merged, Thank you for that! :D

[usergoodvery]

Hi, I have the same problem on 27.0.2. Checking the code though, where exception was thrown, the check for null suggested by @repitch doesn't seem to be in. Is this the most uptodate package: 'com.mahc.custombottomsheetbehavior:googlemaps-like:0.9.2'?

[miguelhincapie]

Hi there, nope, I merged the PR but I still dont push it to bintray. Give me this week and Im gonna do it.

[usergoodvery]

good on you thanks

[usergoodvery]

Hi Is this updated yet?

[Tweener]

Hi,

Just following up on this thread. It would be nice to have the new version, including this fix, uploaded to Bintray. Any idea of when is it supposed to be released?

This library is awesome. Thanks for sharing! Keep on the good work 👍

[miguelhincapie]

Hi there, sorry for the delay, I'm going to set up travis ci, github and bintray to avoid have to do it manually every time. Starting to look how to do it today at night.

[Tweener]

Alright, thanks a lot! Hopefully you won't struggle too much to set this all up :) Keep us posted! Cheers

[miguelhincapie]

New version 0.9.2 here.

I did it manually because linking bintray with travis CI and github is hard to achieve :S. I'm gonna keep trying, if someone wants to join me in the journery here is the link for brintray.gradle file if you wanna understand how it works.

[usergoodvery]

great thanks i'll give that a go

[Tweener]

Hi @miguelhincapie ! Thanks for the upload. About automatic upload to Bintray, I guess you meant "Travis CI", unfortunately, I've never worked with it. I don't know if this can help but better sharing than keeping it for myself: https://github.com/mbonaci/mbo-storm/wiki/Integrate-Travis-CI-with-your-GitHub-repo

[Tweener]

Also I tested the version 0.9.2, and I can confirm I don't have this NPE anymore. So problem fixed, congrats :)