miguelinux314 / experiment-notebook

enb (experiment notebook) is a python library/framework to design, run and analyze computer-based experiments. Persistence, parallelization and plotting can be automatically handled by enb, to help you develop efficient and reproducible science.
https://miguelinux314.github.io/experiment-notebook/
Other
6 stars 10 forks source link

Question regarding the lcnl_codecs.py #54

Closed eoncis closed 1 year ago

eoncis commented 1 year ago

When using the ccsds123-B2 compression algorithm In the lcnl_codecs.py, if bytes_per_sample = 2, dynamic_range = 14, why is large_d = 15 (and not 14)?

miguelinux314 commented 1 year ago

Thank you @eoncis. Indeed, there was a small bug here.

The value of large_d was increased by 1 to avoid large_d=1 (the minimum is 2) for images having dynamic_range = 1. However, this value was incorrectly added as well for all other values of dynamic_range.

It is now solved in the dev branch of the repository, and will be corrected in the next stable release.