aligning with upstream go-ethereum -> removal of sha3 package

miguelmota / ethereum-development-with-go-book

📖 A little guide book on Ethereum Development with Go (golang)

https://goethereumbook.org

Other

1.74k stars 427 forks source link

aligning with upstream go-ethereum -> removal of sha3 package #27

Closed cypherhat closed 5 years ago

cypherhat commented 5 years ago

Had to make this change for my stuff, and I found this repo so useful I figured others might benefit. Upstream geth removed github.com/ethereum/go-ethereum/crypto/sha3. The golang.org/x/crypto/sha3 package contains the same code for NewKeccak256 as NewLegacyKeccak256.

I didn't test - ecrecover.go doesn't compile - but, I figure if you don't want the PR, it will at least be a reminder that this change has to be made.

miguelmota commented 5 years ago

@cypherhat hey jeff, thanks for the PR. ecrecover.go was an artifact that somehow got committed. Merged the PR 👍