search

miguelpaz / normalista

A Jekyll course template for teachers who like to write markdown, host in Github pages and hate worrying about servers
MIT License
24 stars 11 forks source link

Normalista Styleguide v0 #7

Closed davo closed 8 years ago

davo commented 8 years ago

@miguelpaz @jueyang this is the version I've been working on the last couple of days.

Please check the stack, I update the build document (see here https://github.com/davo/normalista/blob/master/BUILD.md).

screen shot 2016-10-30 at 8 51 43 pm

miguelpaz commented 8 years ago

Thanks. I will check everything and wait for @jueyang's comments too.

miguelpaz commented 8 years ago

@davo and @jueyang I get this:

This branch has conflicts that must be resolved. Conflicting files BUILD.md _includes/head.html

miguelpaz commented 8 years ago

Just saw the modifications in BUILD.md and in _includes/head.html. Before accepting the pull request, please @jueyang can you check that changes in _includes/head.html won´t break anything, and how to merge both build.md to not loose the existing documentation but rather update it?

jueyang commented 8 years ago

Hi @davo. Great new flow. I have a few suggestions.

  1. I ran into missing gem warnings using the current flow. Could you add the installation of bundler and run bundle install as part of the installation in BUILD.md. I'm not sure what order you'd like to put it.
  2. Style guide is awesome! I guess the next step would be to add appropriate styles to other layouts. Do you think those happen in the next PR?

I did a small modification of BUILD.md and package.json to consolidate gulp installation based on your PR. See https://github.com/jueyang/normalista/tree/davo-master

miguelpaz commented 8 years ago

Amazing job

miguelpaz commented 7 years ago

Should I close @davo ?