miguelriemoliveira / RansacPlaneDetection

A python API for plane detection in point clouds
12 stars 2 forks source link

[Question] Can not find function 'read_point_cloud' in your code. #3

Closed CaptainEven closed 3 years ago

miguelriemoliveira commented 3 years ago

Hi @CaptainEven ,

where is it called? Can you tell me the script and the code line?

CaptainEven commented 3 years ago

@miguelriemoliveira Thanks for the quick reply! Line 106 in script test_ransac_multiplane.py.

miguelriemoliveira commented 3 years ago

Hi @tiagomfmadeira ,

can you help @CaptainEven with this? This line says negativespade which means you were the last to use it.

I suspect its a funtion from open3d, but am not sure. Can you check please?

CaptainEven commented 3 years ago

@miguelriemoliveira Its's OK now, the problem may be caused by API changing of Open3D, i update them in the code, and it works now! Thank again for your cues for debugging.

miguelriemoliveira commented 3 years ago

Great. Can you please send us a PR for this change?

CaptainEven commented 3 years ago

@miguelriemoliveira Hi, a PR of updating Open3D API calling is created.

miguelriemoliveira commented 3 years ago

Thanks, just accepted the PR.

CaptainEven commented 3 years ago

@miguelriemoliveira Hi, i have create a PR for adding other methods of solving a homogeneous or non-homogeneous linear equations such as over-determined, least square, PCA, SVD, please check.

miguelriemoliveira commented 3 years ago

Thanks. I just merged.

Regards, Miguel

On Thu, 22 Apr 2021 at 07:48, Even @.***> wrote:

@miguelriemoliveira https://github.com/miguelriemoliveira Hi, i have create a PR for adding other methods of solving a homogeneous or non-homogeneous linear equations such as over-determined, least square, PCA, SVD, please check.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/miguelriemoliveira/RansacPlaneDetection/issues/3#issuecomment-824586153, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACWTHVTUAQ5LU5OOMRCULN3TJ7BEJANCNFSM43HTRRMA .

CaptainEven commented 3 years ago

@miguelriemoliveira Got it!