search

miguelsolorio / min-theme

A minimal theme for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=miguelsolorio.min-theme
MIT License
198 stars 20 forks source link

Introduce bold themes #4

Closed tinvaan closed 5 years ago

tinvaan commented 5 years ago

I'm not overly familiar with the theme syntaxes, just a tame hack at adding bold fonts.

miguelsolorio commented 5 years ago

Hey, thanks for the PR! Can I ask why you are looking to add bold fonts? I'm personally not a fan of it but am curious to hear your perspective.

tinvaan commented 5 years ago

Well no particular reason really - fonts are about aesthetics after all no ? :smile:

I'm a huge sucker for bold fonts and with this wonderful theme, the only option for bold font fanboys is to write up one for themselves. I think it would be pretty helpful if this(and every other) theme came with a bold font option by default.

miguelsolorio commented 5 years ago

While I can appreciate your passion for bold fonts, I’m not sure that fits into this theme style. The overall purpose of a “minimal” theme is to keep styles to a minimum while still adding value and I’m not seeing that.

Thanks for taking the time in adding this and will watch for future requests. Might be best to create an issue to allow others to upvote.

tinvaan commented 5 years ago

Alright. Thanks for considering this. I hope you'll consider a minimal theme with bold fonts somewhere in the future. Cheers & thanks for your work!