miguelsolorio / min-theme

A minimal theme for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=miguelsolorio.min-theme
MIT License
198 stars 20 forks source link

Colors for object properties #7

Closed tinvaan closed 5 years ago

tinvaan commented 5 years ago

The theme is great, but off late I've been wondering if it would be possible to support color highlighting for properties of (js) objects. See the image below

image

Wouldn't it be useful to have bar or bar.baz colored differently ? Thoughts ?

miguelsolorio commented 5 years ago

That's an interesting thought, I've mostly seen the entire object + properties highlighted instead of just the properties:

image image image

Night Owl does color them differently though:

image

Not sure how I feel about that but am open to the idea.

tinvaan commented 5 years ago

Yeah I tend to use deep nested objects and at this stage it's almost an OCD where I'm expecting object properties to be colored differently.

I'd love to see this happen. I can attempt a fix for the same but it would be a hit and miss approach really.

miguelsolorio commented 5 years ago

I can attempt as well, I'd have to go look up the textmate markup anyways 😄

tinvaan commented 5 years ago

Thanks let me know if you have something up

tinvaan commented 5 years ago

@misolori What do you think of this ? The changes here are actually quite subtle, notice the following statements

After

image

Let me know your thoughts. Would love to hear some feedback!

miguelsolorio commented 5 years ago

Fixed via https://github.com/misolori/min-theme/pull/11 thanks to @tinvaan