miguelsolorio / vscode-symbols

A file icon theme for VS Code
https://marketplace.visualstudio.com/items?itemName=miguelsolorio.symbols
MIT License
378 stars 67 forks source link

Add folder and file to .test.ts and .spec.ts from Typescript #214

Closed the-spanish-guy closed 1 month ago

the-spanish-guy commented 5 months ago

Description

Issue

Resolves #203

Preview

image

sebastiandotdev commented 5 months ago

I think it would just be changing the folder, I really like the way .spec and .test look now with that orange color.

What do you think @miguelsolorio?

miguelsolorio commented 5 months ago

I'm not a big fan of the more graphical test tube, most of the theme is singular lines. If you could provide some alternative examples that would be great otherwise I'm happy to design some.

sebastiandotdev commented 5 months ago

I agree with you. Maybe we should use folder green or folder red for tests folders. But They are only suggestions, I will send a PR with the idea and tell me what you think.

the-spanish-guy commented 5 months ago

I think it would just be changing the folder, I really like the way .spec and .test look now with that orange color.

What do you think @miguelsolorio?

I like how the folders look with the new icons, I believe that for file icons it is not necessary but for folders I like how they differ from other folders

miguelsolorio commented 5 months ago

I would also only add this for folders, files already have an existing pattern of using blue = source and orange = test from previous file icon themes so I'd like to keep to that.

the-spanish-guy commented 5 months ago

I will revert the file icons and keep the changes to the folder icons

the-spanish-guy commented 5 months ago

@miguelsolorio I updated the description with an image showing the result

miguelsolorio commented 2 months ago

@the-spanish-guy I think you may have missed my original comment about not being a fan of the 3D test tubes, can you provide some different options that fit with the rest of the theme? Otherwise I am happy to add one and close this PR.