search

miguelsolorio / vscode-symbols

A file icon theme for VS Code
https://marketplace.visualstudio.com/items?itemName=miguelsolorio.symbols
MIT License
377 stars 68 forks source link

Extension keeps creating the symbols.hidesExplorerArrows key in settings #232

Closed Sutaai closed 2 months ago

Sutaai commented 3 months ago

Hello,

After using extension bisect, it appears that your extension, as of v0.0.18, keeps creating the symbols.hidesExplorerArrows setting in the user's settings, even after removing the key entirely. Disabling the extension is the only way to not trigger this problem.

I understand if this is a voluntary action, but I think this is an undesirable behavior to the user and shall not be "automatically messing with user's settings".

Thank you.

miguelsolorio commented 3 months ago

I understand the frustration about having your settings modified without doing anything. This was added in https://github.com/miguelsolorio/vscode-symbols/pull/8 and I'll see if I can spend some time to not write to user settings unless there are changes.

miguelsolorio commented 2 months ago

I was able to add some logic to prevent from this issue happening, keep an eye out for v0.0.19 with the fix. Thanks for flagging this ❤️!