miguelsolorio / vscode-symbols

A file icon theme for VS Code
https://marketplace.visualstudio.com/items?itemName=miguelsolorio.symbols
MIT License
377 stars 68 forks source link

Folder Arrows issue on 0.0.19 #239

Closed zacksmash closed 2 months ago

zacksmash commented 2 months ago

First off -- love this icon set! Great job!

I'm seeing a weird issue on the latest version where the folder arrows will randomly come back, even if I have the config setting to disable them. It's especially consistent when using spaces on macOS (video added). Happy to add more detail if necessary!

Thanks again, cheers.

Screenshot 2024-09-05 at 3 25 45 PM

https://github.com/user-attachments/assets/595b4294-9cb3-41a2-ad05-512e1f34a338

miguelsolorio commented 2 months ago

@zacksmash Thanks for filing an issue! We did recently make some changes in the logic for this setting in https://github.com/miguelsolorio/vscode-symbols/issues/232. I can't seem to reproduce, would you mind doing the following:

  1. remove the symbols.hidesExplorerArrows setting
  2. reload VS Code
  3. re-add the setting and see if it persists
zacksmash commented 2 months ago

@miguelsolorio I've followed those instructions and unfortunately it still seems to toggle the arrows visibility when swiping between spaces, or just switching windows. Anything else I can help with?

miguelsolorio commented 2 months ago

You can try downgrading the extension and then updating again? And to verify, this only happens when switching spaces? Doesn't happen when you are in a single space?

zacksmash commented 2 months ago

So, it looks like it happens any time the window is deactivated or unfocused. Here's another video, notice the folder arrows:

https://github.com/user-attachments/assets/92185f8f-6f15-4270-8e2e-17d2d406077a

miguelsolorio commented 2 months ago

Ah ok this is super helpful! Let me see if I can bisect the issue. Thanks again!

zacksmash commented 2 months ago

You got it! Lmk if there's anything else I can do to help debug. Thanks again for this!

miguelsolorio commented 2 months ago

@zacksmash ok I was able to reproduce the bug now and found the line that was causing the bug, can you install this version and verify that this works for you as well? Want to test it before publishing

symbols-0.0.20.vsix.zip

zacksmash commented 2 months ago

@miguelsolorio That looks like it fixed it! Thanks for the quick response!

I also submitted a PR for a file icon #240, lmk if that looks okay.

https://github.com/user-attachments/assets/25259cb0-868b-49e7-89f0-989f2154c696

miguelsolorio commented 2 months ago

Thanks so much for testing, I'll release this out shortly and then will review your PR.

miguelsolorio commented 2 months ago

I actually discovered some more issues, whenever you make any edits/changes to your settings the arrows come back. I'll see if I can fix this properly.

https://github.com/user-attachments/assets/e1949e5e-1cfa-42ef-b408-7d634be91363

miguelsolorio commented 2 months ago

Published 0.0.20 today that should fix this for everyone (changelog)