search

miguelsolorio / vscode-symbols

A file icon theme for VS Code
https://marketplace.visualstudio.com/items?itemName=miguelsolorio.symbols
MIT License
377 stars 68 forks source link

fix: typo in interface icon #242

Closed nikolailehbrink closed 1 month ago

miguelsolorio commented 2 months ago

@nikolailehbrink thanks for the PR, a few things:

  1. Looks like you've also got https://github.com/miguelsolorio/vscode-symbols/pull/243, please consolidate these PRs
  2. Include a screenshot of the extension with your changes
  3. If you are going to rename this you will need to add the old name as well so as to not break existing usage
nikolailehbrink commented 2 months ago

Hi @miguelsolorio, was doing it quickly in GitHub, that's why these are separate. Wanted to make you aware of the mistake, but I have not planned on further working on this MR. Thanks for the package!

miguelsolorio commented 2 months ago

@nikolailehbrink so you don't plan on updating this PR? If you were just wanting to notify of the bug you can just create a regular issue