miguelsolorio / vscode-symbols

A file icon theme for VS Code
https://marketplace.visualstudio.com/items?itemName=miguelsolorio.symbols
MIT License
377 stars 68 forks source link

update deno icon #255

Closed falcao-g closed 1 month ago

falcao-g commented 1 month ago

updates the deno icon to the newly icon made for version 2

miguelsolorio commented 1 month ago

@falcao-g Thanks for the PR, can you please add a screenshot of the extension running with this update? I suspect a black icon on a dark theme will not be very visible. Thanks.

falcao-g commented 1 month ago

hey, of course, here is a image of how it looks, my theme is not that dark (more like purple lol), but it looks fine here

image
miguelsolorio commented 1 month ago

@Vinicius-Marques6 the new branding does not use the blue color anymore https://deno.com/blog/v2.0

Vinicius-Marques6 commented 1 month ago

I understand, but searching the internet I didn't find any occurrence of the logo having been blue at some point, the comparison would be with the logo that is currently used in the extension. The only thing I found was the PR from when the old logo was created (https://github.com/denoland/dotland/pull/1836).

sebastiandotdev commented 1 month ago

@miguelsolorio In vscode is there a way to detect when the user has dark theme colors?. Here is an example of changing the deno.land page to dark mode.

Preview

Captura de pantalla 2024-10-15 a la(s) 3 10 15 p m
falcao-g commented 1 month ago

I adjusted the size of the icon to be equal to the other ones in the extension as per @Vinicius-Marques6 suggestion, the color question i dont exactly know what to do so its the same

miguelsolorio commented 1 month ago

just getting around to previewing this, and I think this is why we went with blue was because the theme is used for both dark and light. So this is what it looks like in a light theme:

CleanShot 2024-10-23 at 10 42 14@2x

We can update the color to use a neutral gray that works in both, and I also found their logo from their site that removes the outline and looks cleaner:

CleanShot 2024-10-23 at 10 53 48@2x

CleanShot 2024-10-23 at 10 53 08@2x

If others feel strongly about the blue, happy to introduce a new variant that folks can override in their settings.

falcao-g commented 1 month ago

the gray one looks good to me

Vinicius-Marques6 commented 1 month ago

LGTM 👍