search

miguelzakharia / aurelia-google-analytics

An Aurelia.io plugin that adds Google Analytics page tracking to your project.
MIT License
29 stars 23 forks source link

Error on loading module when used with Typescript #3

Closed maroy1986 closed 8 years ago

maroy1986 commented 8 years ago

Hi there,

The plugin simply just not load at all when used with Typescript. Here's a screenshot of the error
image

To help find the problem, I've made a repo where you can easily reproduce the issue simply by running the gulp watch command : https://github.com/maroy1986/demo-aurelia-google-analytics-typescript/tree/master/src

I will continu to investigate on my side and report if I find anything.

Thanks!

maroy1986 commented 8 years ago

I just founded that replacing the file included in the jspm package, which are the ES6 version, by the AMD version, makes everything works, That said, I've seen that most of the other package use AMD modules in their package. I'm not sure this is the best way to solve the issue, but a least this is a starting point.

miguelzakharia commented 8 years ago

In that case, version 1.0.3 should work. There was a recent pull request that set it to AMD by default instead of ES6.

maroy1986 commented 8 years ago

That's exactly what I found here last night when I looked at the dist folder in your repo. As I said, I manually replaced the files in jspm_packages folder of your plugin and everything start to work. So yeah, 1.0.3 should work right of the box. Have you any timeline on the release of this update?

Thanks for you time!

miguelzakharia commented 8 years ago

It was released a few days ago.

maroy1986 commented 8 years ago

Actually it doesn't look to work : image

miguelzakharia commented 8 years ago

Odd, I'll look into it today. On Thu, Feb 11, 2016 at 9:44 AM Marc-Andre Roy notifications@github.com wrote:

Actually it doesn't look to work : [image: image] https://cloud.githubusercontent.com/assets/2490360/12979270/055e8af6-d0a4-11e5-84de-f995e65c1492.png

— Reply to this email directly or view it on GitHub https://github.com/miguelzakharia/aurelia-google-analytics/issues/3#issuecomment-182893103 .

maroy1986 commented 8 years ago

I think you just need to create a new Release in your repo, which will create a tag on 1.0.3 and hence, make it work properly ;)

miguelzakharia commented 8 years ago

I just remembered that as well! Thanks for your patience, I'm learning this stuff as I go. :) I just published the release, so check to make sure an update works for you. If so, this issue can be closed.

On Thu, Feb 11, 2016 at 10:03 AM Marc-Andre Roy notifications@github.com wrote:

I think you just need to create a new Release in your repo, which will create a tag on 1.0.3 and hence, make it work properly ;)

— Reply to this email directly or view it on GitHub https://github.com/miguelzakharia/aurelia-google-analytics/issues/3#issuecomment-182899532 .

maroy1986 commented 8 years ago

No problem! I really appreciate your fast response and support! I confirm that it is now working properly when updating from JSPM and it is working when I execute the typescript skeleton.

I'll update the dependency in our application tonight as i'm at work at the moment but for me, this issue can now be closed :)

Thanks again for everything!