Update pom.xml - Githubissues

miguno / java-docker-build-tutorial

A template project to create a minimal Docker image for a Java application. The example app uses Spring Boot to expose an HTTP endpoint.

Apache License 2.0

32 stars 255 forks source link

Update pom.xml #7

Closed Mayank8080 closed 1 year ago

miguno commented 1 year ago

This PR has a few issues, so I am closing it.

The current pom.xml already uses maven.compiler.release, which is better than using the source and target options. From the maven documentation about the aforementioned setting:

This means that, unlike the -source` and -target options, the compiler will detect and generate an error when using APIs that don't exist in previous releases of Java SE. (source)

The PR duplicates the source encoding setting, which already exists in pom.xml.

miguno commented 1 year ago

Also, a general piece of feedback for @Mayank8080: I strongly suggest to always provide a description for any PRs you create on GitHub. It is considered bad manner to create PRs without any information on the PR’s purpose and why you think the PR should be merged.

Mayank8080 commented 1 year ago

Sorry for that

On Wed, 25 Jan, 2023, 12:50 am miguno, @.***> wrote:

Also, a general piece of feedback for @Mayank8080 https://github.com/Mayank8080: I strongly suggest to always provide a description for any PRs you create on GitHub. It is considered bad manner to create PRs without any information on the PR’s purpose and why you think the PR should be merged.

— Reply to this email directly, view it on GitHub https://github.com/miguno/java-docker-build-tutorial/pull/7#issuecomment-1402467742, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3RR2WYAFY7UBVQLBERFCMDWUATPNANCNFSM6AAAAAATVCWOVI . You are receiving this because you were mentioned.Message ID: @.***>

Mayank8080 commented 1 year ago

Thanks for the feedback

On Wed, 25 Jan, 2023, 7:03 am Mayank Sharma, @.***> wrote:

Sorry for that

On Wed, 25 Jan, 2023, 12:50 am miguno, @.***> wrote:

Also, a general piece of feedback for @Mayank8080 https://github.com/Mayank8080: I strongly suggest to always provide a description for any PRs you create on GitHub. It is considered bad manner to create PRs without any information on the PR’s purpose and why you think the PR should be merged.

— Reply to this email directly, view it on GitHub https://github.com/miguno/java-docker-build-tutorial/pull/7#issuecomment-1402467742, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3RR2WYAFY7UBVQLBERFCMDWUATPNANCNFSM6AAAAAATVCWOVI . You are receiving this because you were mentioned.Message ID: @.***>