search

miha42-github / company_dns

An open source micro-service focused that provides company data from EDGAR plus Wikipedia, and SIC lookup.
https://miha42-github.github.io/company_dns/
Apache License 2.0
9 stars 2 forks source link

Add additional URLs to service #11

Closed miha42-github closed 1 year ago

miha42-github commented 1 year ago
miha42-github commented 1 year ago

All tasks confirmed implemented. Additionally, a bug was fixed that where these data and lat long data were not present only when there is Wikipedia data.

During implementation and verification two oddities were encountered:

  1. Wikipedia's stock exchange name and the official stock exchange name differ, and this matters especially when creating a link to Google finance. Essentially, Google is expecting the official name and when not present or slightly off seems to make a recommendation to the right company. More investigation is needed, but it is reasonable as is.

This far the encountered problems are:

  1. For select companies the improvements to make sure Wikipedia only data reports back google links and lat long data isn't working.

This far the following companies do not report back correctly:

  1. While not related to this matter an additional oddity is for:
    • McKinsey and Company - the company type looks like Incorporated [[partnership which is a fix to the parsing operation for this field. Additionally, the city and other location data is None meaning we've not correctly set them to Unknown.

As a result we'll create new issues to track these and over time fix each. At least the definitions is a "treadmill game" because the creation of the exchange name is up to the page author on Wikipedia. This means they could change things and we'd not know.

miha42-github commented 1 year ago

Closing issue and creating three new ones as per the comment above