miha42-github / company_dns

An open source micro-service focused that provides company data from EDGAR plus Wikipedia, and SIC lookup.
https://miha42-github.github.io/company_dns/
Apache License 2.0
9 stars 2 forks source link

Add logo url #21

Closed miha42-github closed 1 year ago

miha42-github commented 1 year ago

The logo filename can be found from the wikipedia data, if you know the wikipedia URL you can derive the total URL to the logo if it exists.

Example: https://en.wikipedia.org/wiki/Alphabet_Inc.#/media/File:Alphabet_Inc_Logo_2015.svg

Ideally, the logo name would be Alphabet_Inc_Logo_2015.svg and the URL would be https://en.wikipedia.org/wiki/Alphabet_Inc.

miha42-github commented 1 year ago

Determined that this will not be a feature as the problem is more complex. Notably the logo file names aren't deterministic and there is an alternative path to solve this problem that is more general. Essentially the Go-base dockerized service called Icon Server will be used externally for deriving the logo image and URL for companies. Therefore, we will close this issue.