miha42-github / company_dns

An open source micro-service focused that provides company data from EDGAR plus Wikipedia, and SIC lookup.
https://miha42-github.github.io/company_dns/
Apache License 2.0
9 stars 2 forks source link

SEC forms are thin #32

Closed miha42-github closed 1 year ago

miha42-github commented 1 year ago

Introduction

For at least the following companies a small number of SEC forms is reported back.

Potential cause

A change was introduced to detect multiple CIKs and only return the values from one CIK, this change could result in there only being the first return. Specifically, the SQL change to include the DISTINCT command could be the culprit. This should be quickly investigated and resolved.

Action

miha42-github commented 1 year ago

Closing as resolved. The logic to remove duplicated companies from what's reported via edgar.get_all_details() actually did not resolve the original matter completely. The change was to make the name of the companies consistent, all uppercase and without any punctuation. However this is likely a quick and weak solution to the problem. A better approach would be to use the CIK as the dict() key and then unwind the structure to be based upon company name. This will be considered for a later date.