search

miha42-github / company_dns

An open source micro-service focused that provides company data from EDGAR plus Wikipedia, and SIC lookup.
https://miha42-github.github.io/company_dns/
Apache License 2.0
9 stars 2 forks source link

Searching for Oracle via wikipedia errors out #6

Closed miha42-github closed 2 years ago

miha42-github commented 2 years ago

Error message:

File "/home/mediumroast/company_dns/company_dns/app/main.py", line 143, in get wiki_data = self.f.get_firmographics_wikipedia() File "/home/mediumroast/company_dns/company_dns/app/lib/firmographics.py", line 89, in get_firmographics_wikipedia return my_query.get_firmographics() File "/home/mediumroast/company_dns/company_dns/app/lib/wikipedia.py", line 165, in get_firmographics if 'type' in company_info and company_info['type'] != None: TypeError: argument of type 'NoneType' is not iterable

miha42-github commented 2 years ago

This appears to be resolved. There were two problems:

  1. Logic errors which didn't check carefully for the existence of keys in dictionaries like wiki_data and edgar_data
  2. A failure to account for a response that includes return codes, errors, messages and data.

Both are fixed now and a soon committed to git.

miha42-github commented 2 years ago

This is confirmed fixed