Closed garex closed 6 years ago
Hey @garex thanks for the effort. I'll have a look at your PR on Saturday.
Sorry for the hassle with the CI, but I'm actually shocked I let the code coverage drop below 100% myself (although that's actually because the newer version of XDebug are more picky).
I'll try to add more info and make the contributing process easier.
Last two commits will broke tests. Anyway we should discuss class types before.
And also how UML diagramm should looks.
May be those two last commits should be in standalone PR with tests to simplify.
@mihaeu which saturday did you mean? ))
60% of time was spent to fix broken tests.
As I undertsand we have here "they are works on my computer".
Anyway current warning in push hook only "! Line coverage is only 97% but should be 100%".
But why does it blocks push if there thereshold?