mihaeu / dephpend

Detect flaws in your architecture, before they drag you down into the depths of dependency hell ...
https://dephpend.com
MIT License
530 stars 26 forks source link

Issue/uml class icons #26

Closed garex closed 6 years ago

garex commented 7 years ago

60% of time was spent to fix broken tests.

As I undertsand we have here "they are works on my computer".

Anyway current warning in push hook only "! Line coverage is only 97% but should be 100%".

But why does it blocks push if there thereshold?

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.8%) to 97.895% when pulling 5d458d0d701158085b8730a1c6cc85b1a247967d on garex:issue/uml-class-icons into 7a931578fb9fe334d14396da8c9255db9ac45f19 on mihaeu:develop.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.9%) to 97.786% when pulling a9338cbea4d54d6ed53c037a8185d01c3eb93729 on garex:issue/uml-class-icons into 7a931578fb9fe334d14396da8c9255db9ac45f19 on mihaeu:develop.

mihaeu commented 7 years ago

Hey @garex thanks for the effort. I'll have a look at your PR on Saturday.

Sorry for the hassle with the CI, but I'm actually shocked I let the code coverage drop below 100% myself (although that's actually because the newer version of XDebug are more picky).

I'll try to add more info and make the contributing process easier.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.9%) to 97.788% when pulling 3f0a6f0f71953aaee3bf8ed4c7bbad7035330c0f on garex:issue/uml-class-icons into 7a931578fb9fe334d14396da8c9255db9ac45f19 on mihaeu:develop.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.9%) to 97.788% when pulling d7335937190af7277d768bade4b18e691d1cf642 on garex:issue/uml-class-icons into 7a931578fb9fe334d14396da8c9255db9ac45f19 on mihaeu:develop.

garex commented 7 years ago

Last two commits will broke tests. Anyway we should discuss class types before.

And also how UML diagramm should looks.

May be those two last commits should be in standalone PR with tests to simplify.

garex commented 7 years ago

@mihaeu which saturday did you mean? ))