mihaeu / dephpend

Detect flaws in your architecture, before they drag you down into the depths of dependency hell ...
https://dephpend.com
MIT License
530 stars 26 forks source link

Docker container rebuild #48

Closed zajca closed 5 years ago

zajca commented 5 years ago

There is an issue with docker container. Image needs to be rebuild one in docker hub is no the one in Dockerfile. Automated build would be great also in docker hub there is no link back to github or builded Dockerfile, this looks kind a bad.

Also would be great if entry point has raised php memory limit. Or in readme could be example how to raise memory limit with docker by overriding entry point.

 docker run -it -v $PWD/src:/inspect --entrypoint "/usr/local/bin/php" mihaeu/dephpend:latest -n -d memory_limit=-1 /usr/src/dephpend/bin/dephpend text /inspect
mihaeu commented 5 years ago

Thanks Martin 😅 will take care of it later this week. Docker build was kind of rushed, I agree 😅

On Mon, May 20, 2019, 3:21 AM Martin Zajíc notifications@github.com wrote:

There is an issue with docker container. Image needs to be rebuild one in docker hub is no the one in Dockerfile. Automated build would be great also in docker hub there is no link back to github or builded Dockerfile, this looks kind a bad.

Also would be great if entry point has raised php memory limit. Or in readme could be example how to raise memory limit with docker by overriding entry point.

docker run -it -v $PWD/src:/inspect --entrypoint "/usr/local/bin/php" mihaeu/dephpend:latest -n -d memory_limit=-1 /usr/src/dephpend/bin/dephpend text /inspect

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mihaeu/dephpend/issues/48?email_source=notifications&email_token=AAQRO7IRFQRHMRDYZQG7I5LPWJNR7A5CNFSM4HN7SDJ2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GUVFGCA, or mute the thread https://github.com/notifications/unsubscribe-auth/AAQRO7PFDQUFWJ4PEXTMWXTPWJNR7ANCNFSM4HN7SDJQ .

mihaeu commented 5 years ago

Should be fixed with f3ba7966975536e16974e508c477bb8837ece905 and 2f8f3e20fc0c4174dcb8170850f2797befba390c. Autobuild is now enabled. Feel free to pull latest and verify @zajca.

And thanks again for the find.