search

mihaeu / dephpend

Detect flaws in your architecture, before they drag you down into the depths of dependency hell ...
https://dephpend.com
MIT License
530 stars 26 forks source link

Incompatible with symfony/event-dispatcher 4.3 #51

Closed brightbyte closed 5 years ago

brightbyte commented 5 years ago

The composer.json file says "symfony/event-dispatcher": "^2.0 || ^3.0 || ^4.0", but the way the Dispatcher is implemented is apparently incompatible with versions 4.3 and later. It seems like no action is performed at all, since the dispatch() method never gets called. With symfony/event-dispatcher 4.2.10, things still work as expected.

mihaeu commented 5 years ago

Thanks @brightbyte will fix it tonight.

By the way, I'm back since July 1st. Wanna talk?

brightbyte commented 5 years ago

By the way, I'm back since July 1st. Wanna talk?

Sure! I'll send you an email.

mihaeu commented 5 years ago

Fixed in 0.6.1 ... breaking bc in a minor ... wtf

I could wrap this and support both versions, but not sure yet if that's worth it. Let's discuss that via phone.