search

mihaeu / dephpend

Detect flaws in your architecture, before they drag you down into the depths of dependency hell ...
https://dephpend.com
MIT License
530 stars 26 forks source link

Upgrade to Symfony5 #60

Closed Sauerbrei closed 4 years ago

Sauerbrei commented 4 years ago

According to https://github.com/mihaeu/dephpend/issues/59 this is a fix for symfony5 integrations

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 5010036f1b662fcdc070ed5acf19fbb85e390192 on Sauerbrei:master into 0d0065a913696a881c7d8c17d7a0ae8e9417cdb1 on mihaeu:master.

mihaeu commented 4 years ago

Thanks for the PR @Sauerbrei :hugs:

I'm going to review it locally soon, but how is switching the argument order going to work with Symfony <5?

Oh god, I should've never used symfony/console ... I regret it so much at this point ...

Sauerbrei commented 4 years ago

Thats a very good point... it seems like to support Symfony 5+ and <5 there have to be two versions...

mihaeu commented 4 years ago

I might have to wrap this in order to work and check for which version is installed :(

Or just drop support of old versions ... hmmm ....

Sauerbrei commented 4 years ago

Hmm, dropping support may be a concern for old projects (I started using this tool for an old project though :D )

mihaeu commented 4 years ago

You're right and that was the feedback that I got from most people. In theory everyone can just download the phar or use the docker container, but many still want to drop it right into the project they are using it for.

I'll check this out over the weekend and see what other options I have. I also have a 2 year old branch where I'm replacing symfony/console for docopt (which is way cleaner, but hat less features).

Sauerbrei commented 4 years ago

Great! If I can help let me know :)

mihaeu commented 4 years ago

Decided to remove Symfony <3 ... people just need to move on. If I get complaints I'll get rid of symfony/console altogether.

Thanks again @Sauerbrei for the PR :hugs: