search

mihaeu / html-formatter

HTML Formatter is a PHP library which pretty prints HTML.
17 stars 11 forks source link

Modified test related to issue #1 #2

Closed ckressibucher closed 6 years ago

ckressibucher commented 9 years ago

I modified the test related to issue #1. In my opinion, removing additional whitespace produces cleaner output, so I think this is ok. The problem in the current implementation is, that a newline gets removed, even if there's no other whitespace between two word. As a result, the visual presentation in the browser shows two words without whitespace in between.

ckressibucher commented 9 years ago

With the last commit, f4f97e2 , I implemented a fix wich only removes newlines when followed by a space character, otherwise it is replaced by a space instead.

mihaeu commented 6 years ago

Thank you so much @ckressibucher

I merged it and also spent a few minutes to upgrade PHPUnit etc. (I feel bad about deprecating this package since lots of people ended up using it, but the code is terrible :( )

Anyways, thanks for the fix!