search

mihaeu / movie-manager

Organize, list, search and filter your movie collection.
4 stars 1 forks source link

Templates front-end dependencies are ignored, but required #4

Closed mihaeu closed 9 years ago

mihaeu commented 9 years ago

From .gitignore

# dependencies
/vendor/
bower_components
node_modules

but in some of the scripts you'll find direct references

{{ filedump('bower_components/jquery/jquery.min.js') }}
{{ filedump('bower_components/bootstrap/dist/js/bootstrap.min.js') }}
{{ filedump('bower_components/tinysort/dist/jquery.tinysort.min.js') }}
{{ filedump('bower_components/fancybox/source/jquery.fancybox.js') }}

The solution would be to use grunt or anything of the kind to extract all the dependencies, merge and compress them.

mihaeu commented 9 years ago

Fixed in 3994577

I went with the lazy option to just copy paste a couple of scripts/stylesheets. Grunt makes more sense for the new theme, the old one's not worth the trouble.