search

mihai-dinculescu / tapo

Unofficial Tapo API Client. Works with TP-Link Tapo smart devices. Tested with light bulbs (L510, L520, L530, L610, L630), light strips (L900, L920, L930), plugs (P100, P105, P110, P115, P300), hubs (H100), switches (S200B) and sensors (KE100, T100, T110, T300, T310, T315).
MIT License
352 stars 36 forks source link

Make past energy usage data optional #71

Closed felixhauptmann closed 1 year ago

felixhauptmann commented 1 year ago

This solves #61 for now. If it turns out that the fields in question do not get readded we can remove them entirely.

mihai-dinculescu commented 1 year ago

Thank you for this contribution.

Tbh, I don't think this functionality is coming back to the get_energy_usage request. I will follow up this PR with the deprecation of these four fields and the addition of the get_energy_data API, which should provide more or less the same functionality.

felixhauptmann commented 1 year ago

Thank you for this contribution.

Tbh, I don't think this functionality is coming back to the get_energy_usage request. I will follow up this PR with the deprecation of these four fields and the addition of the get_energy_data API, which should provide more or less the same functionality.

I just saw your latest commits. Looks good to me. I think deprecating the functionality doesnt hurt. (Btw. Thanks a lot for this awesome project <3)