search

mihai-vlc / spacegray-vscode

Spacegray theme for visual studio code
https://marketplace.visualstudio.com/items?itemName=ionutvmi.spacegray-vscode
MIT License
29 stars 13 forks source link

PHP colors issue. Not matching when braces opened. #12

Open phpbits opened 5 years ago

phpbits commented 5 years ago

Trying to switch to VSCode from Sublime but the colors doesn't match. I've attached images from both editors. Thanks!

Incorrect on VSCode

screen shot 2018-11-26 at 4 58 47 am

Here's how it should look.

screen shot 2018-11-26 at 4 59 24 am
mihai-vlc commented 5 years ago

will have a look at this in the coming weekend meanwhile PRs are welcome

mihai-vlc commented 5 years ago

I have reviewed this and the core issue is in the language processing from VSCode.

It doesn't identify the tokens correctly when the PHP code is embedded in a style tag.

image

We will need to transfer this ticket to the vscode repository to have that issue addressed first.