mihai-vlc / spacegray-vscode

Spacegray theme for visual studio code
https://marketplace.visualstudio.com/items?itemName=ionutvmi.spacegray-vscode
MIT License
29 stars 13 forks source link

Change purple status line to scheme color when no folder selected #13

Closed knoxknox closed 4 years ago

knoxknox commented 4 years ago

When VSCode opens w/o opened folder, status line renders incorrectly. See related issue: https://github.com/ionutvmi/spacegray-vscode/issues/8

This PR fixes this situation, and switch color to background color of scheme.

How to test:

  1. Open this file locally

    ~/.vscode/extensions/ionutvmi.spacegray-vscode-1.2.3/themes/base16-ocean.dark.json

  2. Under colors section add next line

    377: "statusBar.noFolderBackground": "#1c1f26"

  3. Save this file and open VSCode to see related changes

Alternative solution is to add these lines to your settings.json:

"workbench.colorCustomizations": {
  "statusBar.noFolderBackground" : "#1c1f26"
}
knoxknox commented 4 years ago
Screen Shot 2019-11-16 at 8 57 20 PM
knoxknox commented 4 years ago

Hi @ionutvmi, could you review this change ?

mihai-vlc commented 4 years ago

Thank you for the contribution !

mihai-vlc commented 4 years ago

Included in 1.2.4