search

mihai-vlc / sublime-jsfmt

jsfmt plugin for Sublime Text
MIT License
477 stars 21 forks source link

Does not work anymore (reason unknown) #30

Closed pixelass closed 8 years ago

pixelass commented 9 years ago

With the latest update the plugin stopped working for me. It does not matter if I save with autoformat or use try to use the commands (naming also changed? ALL UPPERCASE)

screen shot 2015-09-09 at 4 51 44 pm

If you need more info just ask

mihai-vlc commented 9 years ago

Do you get any errors in the console ? (you can open that by pressing `Ctrl + ``) Also can you try to uninstall and install again ?

If it's not fixed please provide more info about your environment (OS, ST version).

pixelass commented 9 years ago

no errors in console. ST: Build 3083 OS: OS X 10.10.4

EDIT: first thing I tried was remove and add package

mihai-vlc commented 9 years ago

what is your nodejs installed version ? node -v My home pc is currently on 0.12.7 so all the packages installed should work on that.

pixelass commented 9 years ago

v2.3.0

mihai-vlc commented 9 years ago

Is that iojs ? Can you try installing the latest stable version or nodejs https://nodejs.org/en/ ?

royriojas commented 9 years ago

Same here. I use node installed with nvm (0.12.0) if that matters

royriojas commented 9 years ago

Sadly uninstalling/installing didn't fix the issue, and console shows no errors

royriojas commented 9 years ago

It is actually weird, I uninstalled and installed it again and the user settings were still the old user settings. It seems that if there were some plugins there, the update remove them, installing the plugins again made things to work again for me, but still errors were not shown

pixelass commented 9 years ago

@royriojas is it working for you now? what did you change?

royriojas commented 9 years ago

hi @pixelass

  1. unistalled jsfmt
  2. reinstalled jsfmt
  3. I notice that my old jsfmt user settings was there.
  4. I just reinstall the plugins that were listed in my config file. esformatter-jsx, esformatter-quotes, etc... following this guide: https://github.com/royriojas/esformatter-jsx/wiki/Usage-with-jsfmt

And run the command from inside sublime and it was working again

mihai-vlc commented 9 years ago

I have downgraded the get-stdin package, it should now work as before in the 1.0.9 release It should be in the package control in a few hours.

@pixelass can you please check if everything works for you ?

royriojas commented 9 years ago

@ionutvmi Yesterday it stop working for me again, and after redo the steps I did before I also have to modify the path to nodejs.

I guess that something changed in the code in the way jsfmt is detecting the node binary in osx. Since I installed node using nvm the node version in my current path was different from the one detected by jsfmt. And it fails trying to use the Global Promise not available in the version of node detected. Probably downgrading get-stdin package will fix this issue, but in the meantime using a version of node that include the global Promise object will help as well (like node v0.12.0)

mihai-vlc commented 9 years ago

yes, get-stdin was the problem as it required node >= 0.12, I see the new version is already on package control so everything should be fine.

mihai-vlc commented 8 years ago

Closing this as no more problems have been reported.