search

mihaifm / HIBPOfflineCheck

Keepass plugin that performs offline and online checks against HaveIBeenPwned passwords
Other
317 stars 17 forks source link

30gb file #18

Closed Kebap closed 5 years ago

Kebap commented 5 years ago

Heya!

Your readme keeps mentioning the 30gb file download. However, the HIBP website offers different downloads and none match that description:

  1. SHA-1 | Version 4 (ordered by prevalence) | 11.0GB
  2. SHA-1 | Version 4 (ordered by hash) | 9.78GB
  3. NTLM | Version 4 (ordered by prevalence) | 8.85GB
  4. NTLM | Version 4 (ordered by hash) | 7.58GB

Which one is it then? All of them are around 10gb only. I know 1 and 3 are not it, as you mention order by hash. Does the difference between SHA-1 and NTLM matter though?

For the record, I chose 2 and it worked fine. Also, the downloaded file is zipped and will become a circa 23gb textfile after all.

cristianst85 commented 5 years ago

Hi @Kebap.

One needs to download the file with passwords order by hash (SHA-1), in this case the second one.

@mihaifm, I think it's better to remove the file size from README because the file will grow over time as more entries are added to it.

mihaifm commented 5 years ago

Version 4 is 23GB unzipped, but yea, it's probably a good idea to remove the size from the readme.

@cristianst85 Unrelated to this, but can you check my comment on your pull request? I'd like to know what was the issue you addressed there

mihaifm commented 5 years ago

readme has been updated