cleanup and bugfixes - Githubissues

mihaifm / HIBPOfflineCheck

Keepass plugin that performs offline and online checks against HaveIBeenPwned passwords

Other

317 stars 17 forks source link

cleanup and bugfixes #24

Closed dlindhurst closed 5 years ago

dlindhurst commented 5 years ago

[optimize] moved guard clause to top of GetPasswordStatus method to short circuit before computing hash
[bugfix] fixed the default filename
[bugfix] fixed options defaults - GetString wasn't working properly with empty strings
[cleanup] simplified logic in options dialog - use checkbox state instead of explicit true/false
[cleanup] moved HIBPOfflineColumnProv to its own file.
[cleanup] general cleanup following resharper style recommendations

mihaifm commented 5 years ago

Thanks! I'm not a great fan of _variable prefixing, but the rest of the changes look good. I'll merge them after I run some tests.

dlindhurst commented 5 years ago

Thanks for merging! I was never a fan of the underscore naming convention either until I had to use it extensively at a job. It's a great visual that helps make the variable scope immediately apparent. Makes for faster troubleshooting.

Great work putting this extension together. It was a huge help identifying passwords that needed to be updated!