mihaifm / HIBPOfflineCheck

Keepass plugin that performs offline and online checks against HaveIBeenPwned passwords
Other
317 stars 17 forks source link

Use of KeePass Proxy for HIBP online check #46

Closed magl8 closed 2 years ago

magl8 commented 2 years ago

Thank you for this excellent plugin!

Using release 1.7.6, the online check fails in a proxied network because the plugin does not use the proxy setting from Keepass. Could you please use the proxy settings from Keepass (or the system proxy settings if that's easier)?

mihaifm commented 2 years ago

I made the changes but I don't have a proxy server to test this. Can you help test it with the attached .plgx (unzip first)

HIBPOfflineCheck.zip

thanks

magl8 commented 2 years ago

Perfect! Works as expected with KeePass Proxy option set to "Use system Proxy settings". Thank you for the quick fix.

mihaifm commented 2 years ago

Good stuff. I published a new release with this fix. Thanks for getting involved.