search

mihaifm / HIBPOfflineCheck

Keepass plugin that performs offline and online checks against HaveIBeenPwned passwords
Other
317 stars 17 forks source link

Added KeePass (version 2.52) binaries to the repository. #49

Closed cristianst85 closed 1 year ago

cristianst85 commented 1 year ago

Starting with version 2.47, the setup program now installs KeePass into a folder in C:\Program Files by default (see here) - this is for 64-bit OSes which are most of the systems nowadays in which case the KeePass is also 64-bit - which means that the current referenced hint path C:\Program Files (x86)\KeePass Password Safe 2\KeePass.exe is invalid.

There are two ways to fix this, (1) either correct the hint path to point to the C:\Program Files\KeePass Password Safe 2 instead, which I assume might break the build for some people, or (2) add the KeePass binaries to the repository (which this PR does) that guarantees to work for everyone. There are pros and cons with the latter; the pro is that it gives better control when the KeePass API changes (everyone references the same KeePass version at build time); the con is that from time to time, the KeePass binaries must be updated (the frequency of KeePass releases is not that big - two or three releases a year) and that some people might not feel comfortable of adding binaries to their source control (KeePass binaries are digitally signed anyway).

mihaifm commented 1 year ago

Let's go with the first option of updating the hint path, I'm not a great fan of putting binaries in code repositories. Thanks for PR though :)

cristianst85 commented 1 year ago

Okay then, I am gonna close this PR and create another one.